Skip to content

Fix param in create LB Stickyness policy command #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishesh92 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix param in create LB Stickyness policy command #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50c1cf
Fix param in create LB Sticky policy command
vishesh92 Dec 2, 2025
6c70a38
Fix list stickyness policy response
vishesh92 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloudstack/LoadBalancerService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ func (p *CreateLBStickinessPolicyParams) toURLValues() url.Values {
if v, found := p.p["param"]; found {
m := v.(map[string]string)
for i, k := range getSortedKeysFromMap(m) {
u.Set(fmt.Sprintf("param[%d].key", i), k)
u.Set(fmt.Sprintf("param[%d].name", i), k)
Copy link
Member

@weizhouapache weizhouapache Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any potential regression due to this ?
@vishesh92

u.Set(fmt.Sprintf("param[%d].value", i), m[k])
}
}
Expand Down Expand Up @@ -3782,7 +3782,7 @@ func (s *LoadBalancerService) ListLBStickinessPolicies(p *ListLBStickinessPolici

type ListLBStickinessPoliciesResponse struct {
Count int `json:"count"`
LBStickinessPolicies []*LBStickinessPolicy `json:"lbstickinesspolicy"`
LBStickinessPolicies []*LBStickinessPolicy `json:"stickinesspolicies"`
}

type LBStickinessPolicy struct {
Expand Down
6 changes: 6 additions & 0 deletions generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,9 @@ func (s *service) generateConvertCode(cmd, name, typ string) {
case "otherdeployparams":
pn(" u.Set(fmt.Sprintf(\"%s[%%d].name\", i), k)", name)
pn(" u.Set(fmt.Sprintf(\"%s[%%d].value\", i), m[k])", name)
case "param":
pn(" u.Set(fmt.Sprintf(\"%s[%%d].name\", i), k)", name)
pn(" u.Set(fmt.Sprintf(\"%s[%%d].value\", i), m[k])", name)
case "nodeofferings":
pn(" u.Set(fmt.Sprintf(\"%s[%%d].node\", i), k)", name)
pn(" u.Set(fmt.Sprintf(\"%s[%%d].offering\", i), m[k])", name)
Expand Down Expand Up @@ -2096,6 +2099,9 @@ func (s *service) generateResponseType(a *API) {
case "quotaSummary":
pn(" Count int `json:\"count\"`")
pn(" %s []*%s `json:\"%s\"`", ln, parseSingular(ln), "summary")
case "listLBStickinessPolicies":
pn(" Count int `json:\"count\"`")
pn(" %s []*%s `json:\"%s\"`", ln, parseSingular(ln), "stickinesspolicies")
default:
pn(" Count int `json:\"count\"`")
pn(" %s []*%s `json:\"%s\"`", ln, parseSingular(ln), strings.ToLower(parseSingular(ln)))
Expand Down
Loading