Fix and run gp_exttable_fdw tests #1516
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "format" with "format_type", because the format option is not supported
leborchuk
approved these changes
Dec 30, 2025
Contributor
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
Interesting, we broke it in 24bc252
But the issue is that PR was OK at the time of creation, it's just conflicting with bae29f3
We cannot find these conflicts in the tests. And could re-run the entire test suite before merging again, but it is too costly. Anyway it could be found later just regularly running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "format" with "format_type", because the format option is not supported