[CELEBORN-2264] Support cancel shuffle when write bytes exceeds threshold #3601
+93
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
- Coverage 67.13% 66.91% -0.22%
==========================================
Files 357 357
Lines 21860 21932 +72
Branches 1943 1949 +6
==========================================
Hits 14674 14674
- Misses 6166 6244 +78
+ Partials 1020 1014 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yew1eb
force-pushed
the
CELEBORN_2264
branch
from
d15feca to
2182ddb
Compare
yew1eb
force-pushed
the
CELEBORN_2264
branch
from
2182ddb to
9522ca4
Compare
yew1eb
force-pushed
the
CELEBORN_2264
branch
from
9522ca4 to
65ee9d9
Compare
yew1eb
force-pushed
the
CELEBORN_2264
branch
from
7ebf5d1 to
d7c7080
Compare
yew1eb
force-pushed
the
CELEBORN_2264
branch
from
d7c7080 to
4a513c7
Compare
eolivelli
suggested changes
Feb 11, 2026
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I have left one question about protocol compatibility
Can you please add some unit tests ?
| bytesWrittenPerPartition: Array[Long], | ||
| serdeVersion: SerdeVersion) | ||
| serdeVersion: SerdeVersion, | ||
| bytesWritten: Long) |
Contributor
There was a problem hiding this comment.
IIUC this patch is changing the protocol
how is this handled ?
will the new client be compatible with the new server version and viceversa ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds configurable threshold check for shuffle write bytes.
Why are the changes needed?
Shuffle will be canceled automatically if write bytes exceed the threshold to avoid cluster resource exhaustion.
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI and Manual testing