[CELEBORN-2143] Create DiskFile sequentially based on createFileOrder#3594
Open
xy2953396112 wants to merge 1 commit intoapache:mainfrom
Open
[CELEBORN-2143] Create DiskFile sequentially based on createFileOrder#3594xy2953396112 wants to merge 1 commit intoapache:mainfrom
xy2953396112 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
hello @xy2953396112 maybe we could merge my patch and then rebase this patch ? |
Contributor
|
I am reviewing this patch. |
eolivelli
reviewed
Feb 12, 2026
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Overall LGTM
I have left some suggestions
| retryCount += 1 | ||
| } | ||
| if (dfsStorageAvailable) { | ||
| logWarning("Failed to create localFileWriter", exception) |
| partitionDataWriterContext, | ||
| storageManager) | ||
| } else { | ||
| null |
Contributor
There was a problem hiding this comment.
I suggest to add logDebug for these cases that return "null", sometimes I saw errors and I did not understand the reason
| partitionDataWriterContext, | ||
| storageManager) | ||
| } else { | ||
| null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create DiskFile sequentially based on createFileOrder.
Why are the changes needed?
Does this PR resolve a correctness bug?
NO
Does this PR introduce any user-facing change?
NO
How was this patch tested?
CI