GH-44248: [Format] Add TimestampWithOffset canonical extension type #48002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serramatutu
changed the title
serramatutu
force-pushed
the
serramatutu/TimestampWithOffset/format
branch
from
14fd59a to
fe8056f
Compare
rok
reviewed
Oct 30, 2025
github-actions
bot
added
awaiting changes
lidavidm
reviewed
Nov 3, 2025
github-actions
bot
added
awaiting change review
serramatutu
commented
Nov 5, 2025
github-actions
bot
added
awaiting change review
serramatutu
force-pushed
the
serramatutu/TimestampWithOffset/format
branch
from
d40c0bb to
b0d9be3
Compare
serramatutu
force-pushed
the
serramatutu/TimestampWithOffset/format
branch
from
6ab0deb to
d4d50b3
Compare
pitrou
reviewed
Nov 20, 2025
pitrou
reviewed
Nov 20, 2025
pitrou
reviewed
Nov 20, 2025
felipecrv
changed the title
|
|
- Drop JSON encoding recommendation - Inner fields must be non-nullble - Time unit is not a type parameter
alamb
reviewed
Nov 21, 2025
alamb
reviewed
Nov 21, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks for this PR @serramatutu -- the basic idea looks good to me
github-actions
bot
added
awaiting changes
jorisvandenbossche
approved these changes
Nov 25, 2025
wgtmac
reviewed
Nov 25, 2025
github-actions
bot
added
awaiting merge
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
felipecrv
approved these changes
Nov 25, 2025
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
pitrou
changed the title
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b10386e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #44248
Arrow has no built-in canonical way of representing the
TIMESTAMP WITH TIME ZONESQL type, which is present across multiple different database systems. Not having a native way to represent this forces users to either convert to UTC and drop the time zone, which may have correctness implications, or use bespoke workarounds. A newarrow.timestamp_with_offsetextension type would introduce a standard canonical way of representing that information.Rust implementation: apache/arrow-rs#8743
Go implementation: apache/arrow-go#558
[DISCUSS] thread in the mailing list.
What changes are included in this PR?
Proposal and documentation for
arrow.timestamp_with_offsetcanonical extension type.Are these changes tested?
N/A
Are there any user-facing changes?
Yes, this is an extension to the arrow format.