Fix: Improve plugin icons rendering and responsiveness on Plugins Page #1963#1964
Open
adarsh-priydarshi-5646 wants to merge 2 commits intoapache:masterfrom
Open
Fix: Improve plugin icons rendering and responsiveness on Plugins Page #1963#1964adarsh-priydarshi-5646 wants to merge 2 commits intoapache:masterfrom
adarsh-priydarshi-5646 wants to merge 2 commits intoapache:masterfrom
Conversation
…obile responsive design ✨ Hero Section Enhancements: - Enhanced background image visibility with CSS filters (contrast 1.1, brightness 1.05, saturation 1.1) - Added subtle backdrop blur for better text readability - Improved visual hierarchy while maintaining text clarity - Enhanced button styling with proper hover effects 📱 Mobile Responsive Improvements: - Architecture section: Fixed text overflow with proper text wrapping and container constraints - Features section: Optimized text sizes and widths for all mobile devices - EndCTA section: Adjusted button sizes and text for better mobile experience - Added comprehensive breakpoint coverage (768px, 480px, 360px) 🎯 Button Enhancements: - Standardized button styling across all sections - Added proper hover effects with color transitions - Optimized button sizes for different screen sizes - Improved touch targets for mobile devices 🛠️ Technical Improvements: - Progressive text scaling for smooth responsive transitions - Proper CSS containment to prevent overflow issues - Optimized performance with efficient CSS properties - Cross-browser compatibility maintained 📊 Device Coverage: - Desktop: Enhanced background visibility and professional styling - Tablets (768px): Medium-sized optimizations - Mobile (480px): Compact layouts with readable text - Extra Small (360px): Ultra-compact designs for tiny screens All changes maintain backward compatibility and improve user experience across all devices.
yzeng25
requested review from
Baoyuantop,
LiteSun,
SkyeYoung,
bzp2010,
guoqqqi and
juzhiyuan
Contributor
|
Hi @adarsh-priydarshi-5646, thank you for your contribution, we will review it as soon as possible. |
Author
|
@Yilialinn Please review. |
Member
|
@guoqqqi pls have a look |
There was a problem hiding this comment.
Pull request overview
This PR claims to fix plugin icon rendering issues and improve responsiveness on the Plugins Page. However, the changes extend far beyond the stated scope, including a complete visual redesign of the landing page with new hero section styling, navbar overhauls, animations, and extensive responsive breakpoints across multiple components.
Changes:
- Modified plugin icon rendering logic in
plugins.tsxto use a hardcoded plugin name list instead of metadata - Removed Translate component from Architecture section, breaking i18n support
- Added scroll-based navbar styling that changes appearance in hero section
- Complete visual redesign of hero section with new animations (float, pulse, glow), color schemes, and layout
- Extensive responsive design updates across hero, features, architecture, and endcta sections
- Added new navbar styling with glassmorphic effects and mobile menu enhancements
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/pages/plugins.tsx | Changed icon rendering from metadata-driven to hardcoded list approach; logic appears inverted from original |
| website/src/css/landing-sections/hero.scss | Major redesign with 600+ new lines: animations, responsive breakpoints, color scheme changes, layout restructuring |
| website/src/css/landing-sections/features.module.scss | Added responsive breakpoints for tablet and mobile devices |
| website/src/css/landing-sections/endcta.module.scss | Added button styling and responsive breakpoints |
| website/src/css/landing-sections/architecture.scss | Added responsive breakpoints and text wrapping improvements |
| website/src/css/customTheme.scss | Complete navbar redesign with glassmorphic effects, hero-specific styling, mobile menu enhancements |
| website/src/components/sections/HeroSection.tsx | Added scroll listener for dynamic navbar styling; removed mobile canvas check |
| website/src/components/sections/Architecture.tsx | Removed Translate component and hardcoded English text with manual line breaks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@Yilialinn I’ve been waiting for the past two months. Could you please review the PR so I can continue contributing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1963
Changes Made
plugin-icon.js.These updates ensure that plugin icons display properly across all browsers and screen sizes, improving the overall user experience when browsing available plugins.
Screenshots of the change
Before Changes
After Changes