Tony/149 highlight selected menu item

[tonypioneer]

Pull Request Details

What issue does this PR address

• When the page is navigated to a page that is in the navigation menu (even when using the app bar icons), the selected menu item will be updated, and the icon of the menu item will be highlighted.

Associated Issue

• This PR relates to issue SOLIDUI MENU: selected menu item not updating after app bar nav #149

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the NotePod app using this branch.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue #
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[gjwgit]

Tested on Linux - works as advertised.

[jesscmoore]

Works well in notepod, can it also be tested in other apps using solidui?

[jesscmoore]

Hi @tonypioneer This method of testing match of current page to menu items, requires each menu item to have a separate type which is smart and should work for apps. Works great in Notepod. However to confirm, lets have reviewers test the PR in other apps.

[tonypioneer]

Thanks @jesscmoore. I have tested it SolidUI Example app and Notepod, because there have already been some navigation buttons in the appbar of these two apps, the testing will be easier. I haven't tested it in other apps yet.

[jesscmoore]

Tested on Linux - works as advertised.

@gjwgit did you test in healthpod/geopod/rio using solidui? Would be good to check apps other than notepod