-
Notifications
You must be signed in to change notification settings - Fork 50
feat: support legend render #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @moayuisuda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of legend rendering by introducing support for custom HTML content. Users can now provide a custom render function to define the visual representation of legends, moving beyond the default component-based rendering. This feature allows for more diverse and tailored legend designs, making the UI components more adaptable to specific charting and visualization needs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for custom rendering of legends using an HTML-based approach. The changes introduce a new render attribute that, when provided, uses a custom function to generate the legend's content as HTML. My review focuses on improving type safety, correcting a type assertion bug, and simplifying the code. Overall, the changes are well-structured to support this new feature.
| update(options: any) { | ||
| this.attr(options); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| container.style.transform = `translate(${x}, ${y})`; | ||
|
|
||
| this.renderTitle(ctn, width!, height!); | ||
| if (render as CategoryStyleProps['render']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.