Suggestion: modify "keyQuit" key behavior in search mode#178
Open
rustyhu wants to merge 2 commits intoantonmedv:masterfrom
Open
Suggestion: modify "keyQuit" key behavior in search mode#178rustyhu wants to merge 2 commits intoantonmedv:masterfrom
rustyhu wants to merge 2 commits intoantonmedv:masterfrom
Conversation
search mode, not to quit entire program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify to make "keyQuit" key able to only quit search mode, not to quit entire program.
When in search mode, after typing some chars and matching, user may want to cancel all typed chars (quit search mode) to do others, intuitively pressing "keyQuit" (Esc). In current logic this would lead to quit the entire program, which is often not what user want. I think this modification would improve user experience.