types(function): invoke infer the invoked fn's return type#48
Merged
antfu merged 1 commit intoantfu:mainfrom Feb 15, 2025
Merged
types(function): invoke infer the invoked fn's return type#48antfu merged 1 commit intoantfu:mainfrom
invoke infer the invoked fn's return type#48antfu merged 1 commit intoantfu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current logic allows/already returns the invoked function's result, but the result type is
void, inferred fromFntype, so thereturnis basically meaningless on projects with type-checking.Additional context
The
invokeutil that is used in@vueuse/core(here), which is added by @antfu in 2020, infer the invoked fn's type correctly, and I have been using it for years, I just realized theinvokein this repo doesn't match the one in@vueusewhen attempting to use it on a non-Vue project to wrap a logic block into a background promise.I just copied
@vueuse's invoke over.