Skip to content

Conversation

@StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Aug 6, 2025

Description

Implment property based approach

Issue linked

#685

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene linked an issue Aug 6, 2025 that may be closed by this pull request
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys can you have alook why the test_camera_modify_after_reset test is failing

@StefanThoene
Copy link
Collaborator Author

@SMoraisAnsys could you review the refactor?

@pluAtAnsys
Copy link
Collaborator

@pluAtAnsys can you have alook why the test_camera_modify_after_reset test is failing

feat_ssrs[0].set_type_colorimetric().set_wavelengths_range().set_end(value=800)
should be:
feat_ssrs[0].set_type_colorimetric().set_wavelengths_range().end = 800

@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys can you have alook why the test_camera_modify_after_reset test is failing

feat_ssrs[0].set_type_colorimetric().set_wavelengths_range().set_end(value=800) should be: feat_ssrs[0].set_type_colorimetric().set_wavelengths_range().end = 800

That is the project unit test...

i didn'T even know yet that it is failing... i started with the sensor test

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 7, 2025
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.94%. Comparing base (d262cd9) to head (2f54f87).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   88.99%   86.94%   -2.06%     
==========================================
  Files          39       41       +2     
  Lines        5653     6671    +1018     
==========================================
+ Hits         5031     5800     +769     
- Misses        622      871     +249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor sensor

5 participants