-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: sensor #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: sensor #691
Conversation
fix minor issues on sensors classes
minor fix on radiance class
|
@pluAtAnsys can you have alook why the test_camera_modify_after_reset test is failing |
|
@SMoraisAnsys could you review the refactor? |
feat_ssrs[0].set_type_colorimetric().set_wavelengths_range().set_end(value=800) |
That is the project unit test... i didn'T even know yet that it is failing... i started with the sensor test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 88.99% 86.94% -2.06%
==========================================
Files 39 41 +2
Lines 5653 6671 +1018
==========================================
+ Hits 5031 5800 +769
- Misses 622 871 +249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # tests/core/test_sensor.py
Co-authored-by: Pengyuan LU <89462462+pluAtAnsys@users.noreply.github.com>
for more information, see https://pre-commit.ci
Description
Implment property based approach
Issue linked
#685
Checklist
feat: add optical property)