Skip to content

fix(@angular/cli): update yarn berry package manager configuration #32206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −5
Open

fix(@angular/cli): update yarn berry package manager configuration #32206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9635082
fix(@angular/cli): update yarn berry package manager configuration
clydin Dec 29, 2025
2317262
fix(@angular/cli): handle array output from npm view in manifest parser
clydin Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/angular/cli/src/package-managers/package-manager-descriptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ export const SUPPORTED_PACKAGE_MANAGERS = {
saveExactFlag: '--exact',
saveTildeFlag: '--tilde',
saveDevFlag: '--dev',
noLockfileFlag: '--no-lockfile',
ignoreScriptsFlag: '--ignore-scripts',
getRegistryOptions: (registry: string) => ({ env: { NPM_CONFIG_REGISTRY: registry } }),
noLockfileFlag: '',
ignoreScriptsFlag: '--mode=skip-build',
getRegistryOptions: (registry: string) => ({ env: { YARN_NPM_REGISTRY_SERVER: registry } }),
versionCommand: ['--version'],
listDependenciesCommand: ['list', '--depth=0', '--json', '--recursive=false'],
getManifestCommand: ['npm', 'info', '--json'],
Expand Down
4 changes: 3 additions & 1 deletion packages/angular/cli/src/package-managers/parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ export function parseNpmLikeManifest(stdout: string, logger?: Logger): PackageMa
return null;
}

return JSON.parse(stdout);
const result = JSON.parse(stdout);

return Array.isArray(result) ? result[result.length - 1] : result;
}

/**
Expand Down
21 changes: 20 additions & 1 deletion packages/angular/cli/src/package-managers/parsers_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { parseNpmLikeError, parseYarnClassicError } from './parsers';
import { parseNpmLikeError, parseNpmLikeManifest, parseYarnClassicError } from './parsers';

describe('parsers', () => {
describe('parseNpmLikeError', () => {
Expand Down Expand Up @@ -69,6 +69,25 @@ describe('parsers', () => {
});
});

describe('parseNpmLikeManifest', () => {
it('should parse a single manifest', () => {
const stdout = JSON.stringify({ name: 'foo', version: '1.0.0' });
expect(parseNpmLikeManifest(stdout)).toEqual({ name: 'foo', version: '1.0.0' });
});

it('should return the last manifest from an array', () => {
const stdout = JSON.stringify([
{ name: 'foo', version: '1.0.0' },
{ name: 'foo', version: '1.1.0' },
]);
expect(parseNpmLikeManifest(stdout)).toEqual({ name: 'foo', version: '1.1.0' });
});

it('should return null for empty stdout', () => {
expect(parseNpmLikeManifest('')).toBeNull();
});
});

describe('parseYarnClassicError', () => {
it('should parse a 404 from verbose logs', () => {
const stdout =
Expand Down