Open
Conversation
Refactor ShapeElement class to improve caching and transformation handling.
Refactor ClientAnimator class to improve structure and performance. Update matrix calculations and optimize animation handling.
Multiply improvment
Enhance caching and transformation logic in ShapeElement
tyronx
reviewed
Feb 13, 2026
| /// <summary> | ||
| /// Flag indicating that the cache is stale | ||
| /// </summary> | ||
| private bool _isCacheDirty = true; |
Contributor
There was a problem hiding this comment.
hey, i don't quite understand what this flag is for. This only seems to be set to true when a ShapeElement object was created and then never again? Why not just null check the matrixes then?
bool _isCacheDirty => _cachedBaseMatrixV0==null || _cachedBaseMatrixV1==null;
tyronx
reviewed
Feb 13, 2026
| /// Cached base matrices for different animation versions | ||
| /// </summary> | ||
| private float[] _cachedBaseMatrixV0; | ||
| private float[] _cachedBaseMatrixV1; |
Contributor
There was a problem hiding this comment.
please no _ prefixes, we don't use these in our code base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following improvements have been made to the animation system:
1) ClientAnimator:
2) ShapeElement:
3) Mat4f:
On my test map with a large number of block entities with animations, we get the following results: