-
Notifications
You must be signed in to change notification settings - Fork 315
Add AI glasses projected snippets #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @trambui09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for AI glasses integration by incorporating essential Extended Reality (XR) libraries. It establishes a dedicated activity for the glasses display and a companion phone application that intelligently manages the connection to the glasses, enabling the launch of the glasses experience only when a device is actively connected. This ensures a seamless and context-aware user experience for projected content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a projected activity for AI glasses, along with a phone-side activity to launch it. It adds the necessary glimmer and projected dependencies. The implementation correctly uses ProjectedContext to check for device connection and to launch the glasses activity. My review includes critical feedback on declaring the new activities in the Android Manifest, which is currently missing and would cause the app to crash. I've also suggested a class rename for consistency and a minor formatting improvement for better code readability.
| import androidx.xr.glimmer.surface | ||
|
|
||
| // [START androidxr_projected_ai_glasses_activity] | ||
| class GlassesMainActivity : ComponentActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlassesMainActivity is not declared in xr/src/main/AndroidManifest.xml. All activities must be declared in the manifest file. For a projected activity, it should be declared with android:theme="@android:style/Theme.NoDisplay" and an intent filter for androidx.xr.projected.ACTION_BIND_PROJECTED_SERVICE. For example:
<activity
android:name=".projected.GlassesMainActivity"
android:exported="true"
android:theme="@android:style/Theme.NoDisplay">
<intent-filter>
<action android:name="androidx.xr.projected.ACTION_BIND_PROJECTED_SERVICE" />
</intent-filter>
</activity>| fun HomeScreen(modifier: Modifier = Modifier, onClose: () -> Unit) { | ||
| Box( | ||
| modifier = modifier | ||
| .surface(focusable = false).fillMaxSize(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
| import androidx.xr.glimmer.surface | ||
|
|
||
| // [START androidxr_projected_ai_glasses_activity] | ||
| class GlassesMainActivity : ComponentActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you already have the code for an activity, do you want to add these activities to the manifest file for the xr module? If not, that's okay too, not a blocking comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. This is important! And will be part of the snippets too. Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to add the region tags in the manifest file?
Would it be?
[END androidxr_projected_ai_glasses_activity_manifest] -->```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah per our snippets criteria, you can actually omit the region tags from the manifest and leave that hardcoded in the documentation pages. It would get more complicated as more docs need to reference parts of the manifest file and there's no way to have overlapping region tags.
xr/src/main/java/com/example/xr/projected/GlassesMainActivity.kt
Outdated
Show resolved
Hide resolved
gradle/libs.versions.toml
Outdated
| wearPhoneInteractions = "1.1.0" | ||
| wearRemoteInteractions = "1.1.0" | ||
| xrGlimmer = "1.0.0-alpha03" | ||
| projected = "1.0.0-alpha03" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: also change to xrProjected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, I had it changed and forgot to push it up! done!
| import androidx.xr.glimmer.surface | ||
|
|
||
| // [START androidxr_projected_ai_glasses_activity] | ||
| class GlassesMainActivity : ComponentActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah per our snippets criteria, you can actually omit the region tags from the manifest and leave that hardcoded in the documentation pages. It would get more complicated as more docs need to reference parts of the manifest file and there's no way to have overlapping region tags.
kkuan2011
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from snippets repo perspective. Defer to XR/Compose DRE for the XR-related and lifecycle handling parts.
| android:name="com.example.xr.projected.PhoneMainActivity" | ||
| android:exported="true"> | ||
| <intent-filter> | ||
| <action android:name="android.intent.action.MAIN" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you have two activities with the Main intent filter?
Include:
ProjectedContext.isProjectedDeviceConnected()method