Updated dependencies and code accordingly#99
Updated dependencies and code accordingly#99tegner wants to merge 1 commit intoandreassolberg:masterfrom
Conversation
|
We ran into this issue recently. |
|
@andreassolberg can we get this pull request approved? A fresh install of JSO throws errors without it. |
|
@andreassolberg As of now every project that has core-js v3+ as a dependency is not able to use JSO. This pr will solve that. Can we please get this approved? |
|
Can we use this somehow in our projects ? If so, how would I update this plugin to use the updated files? Thank you |
I have now published a package with the only change being the updated dependencies |
|
Can you guys walk me through how to update my copy of jso to the one with the updated dependencies? I thought I would run Update: Ok, so i had to change my import statement from |
|
This PR changes quite a few unrelated things though (style changes etc. in JSO.js). @tegner maybe better to submit one that only updates the deps, and do a separate PR for the stylistic stuff? Would make it easier on @andreassolberg to review. |
|
Any progress on this? Or, anyone have suggestions on an alternate package that would allow us to use a custom provider rather than Facebook, Google, etc? |
I was having trouble with this module after updating my other dependencies.
The problems were specific to core-js and the way it was included.
But I thought a thorough update of dependencies would help.