Fix state in search (/blabla?state=STATE#access_token=TOKEN)#45
Open
galeksandrp wants to merge 2 commits intoandreassolberg:masterfrom
Open
Fix state in search (/blabla?state=STATE#access_token=TOKEN)#45galeksandrp wants to merge 2 commits intoandreassolberg:masterfrom
galeksandrp wants to merge 2 commits intoandreassolberg:masterfrom
Conversation
mastef
added a commit
to mastef/jso
that referenced
this pull request
Feb 21, 2019
`getResponseFromURL` returns now a combined object in which both params from `#` and `?` are combined. This fixes cases such as in andreassolberg#86 and andreassolberg#45
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OAuth2 providers (soundcloud.com for example) put state in URL search (/blabla?state=STATE#access_token=TOKEN) parameter. This dirty fix concatenates searchstring&hash and send it to parseQueryString.