Merged
Conversation
andersfugmann
force-pushed
the
andersfugmann/fix_zigzag_decoding
branch
from
3f3aad4 to
e8f9e48
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes zigzag decoding for large integers by correcting the division operation and extends test coverage for edge cases. The fix addresses issue #45 by replacing integer division with logical right shift operations in zigzag decoding functions.
- Replace integer division (
/) with logical right shift (lsr) in zigzag decoding functions - Add comprehensive test coverage for extreme integer values (min/max integers)
- Update expect tests to include new test cases for better edge case coverage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ocaml_protoc_plugin/deserialize.ml | Fixes zigzag decoding logic by using logical right shift instead of division and adds comprehensive test cases |
| test/int_types_native_test.ml | Extends test coverage to include minimum and maximum integer values for both 32-bit and 64-bit signed integers |
| src/ocaml_protoc_plugin/serialize.ml | Minor formatting fix to expect test output |
andersfugmann
force-pushed
the
andersfugmann/fix_zigzag_decoding
branch
from
9a4b273 to
7d742e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45