Skip to content

Conversation

@zevweiss
Copy link
Contributor

I understand if this is a bit "controversial" (i.e. not wanted); it's definitely a bit of a hack, but it does let virtme work in some situations where it currently doesn't.

@amluto
Copy link
Owner

amluto commented Nov 25, 2017

There were some other fixes recently to help find a static busybox. Is this still needed?

@zevweiss
Copy link
Contributor Author

"Needed" might be a bit strong; still potentially useful in some cases though. I'm not aware offhand of any distros that don't package a static build of busybox, though as seen in commit c39a1cd they may be under different names (e.g. on my current system it's /usr/bin/busybox.static -- note the . instead of -). We could just add another entry to the hard-coded list in find_busybox(), but trying to accommodate dynamically-linked builds might make it slightly more likely to "just work" on arbitrary/unknown other systems -- though as previously noted, the patch isn't entirely a thing of beauty, so if you'd prefer the former I wouldn't particularly mind.

@zevweiss
Copy link
Contributor Author

Ping...any further thoughts on this?

Support dynamically-linked busyboxen by ldd-ing them and copying any
libraries they're linked against into the initramfs.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
It's a hack, but it lets virtme run on some distros where it otherwise
doesn't (e.g. Void).

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
@jadahl
Copy link

jadahl commented Aug 17, 2022

Just noticed this, after having implemented an equivalent variant of this but using pyelftools instead of parsing ldd: #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants