-
Notifications
You must be signed in to change notification settings - Fork 28
feat(specs): add advanced personalization profile type #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
3b1bf07 to
ae594aa
Compare
Fluf22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
|
@raed667 okay to merge? |
| example: 'session' | ||
|
|
||
| userType: | ||
| title: userType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should be
| title: userType | |
| title: type |
@Fluf22 what do you think ? i'm having doubts 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might end up with restricted name conflicts in some language and weird random name from the generator 🥶
🧭 What and Why
Add
Advanced Personalizationprofile attributetype