Browaeys and Chevrot [work in progress] #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like MSAT, this makes use of the Bond transform to avoid the matrix to tensor change and do the rotation as two matrix products. Thus far the user is expected to provide an explicit rotation matix.
Check the bond transform for an the identity matrix and 90 degree rotations around X1, X2 and X3.
Matrix for bond transform had a one-character error causing (for example) rotation around b to fail. This also fixes seems to fix my VTI bug.
We don't need to print the Bond transform matrix
Check the matrix is positive definate. We have more checks to include.
This is a translation of the MATLAB code I used to compare VPSC results for D'' with global anisotropic tomography. We have a single test point, which works, as a test.
This has a test for norms and a non-working stub function.
At least, it passes the olivine test case. The API probably needs a bit of thought. Return a numpy array?
As per MSAT implementation of B&C
decomp.axes() is a re-implementation of MS_axes, with support for selection of X3 based on symmetry or on the stiff direction. We also add some simple tests (for olivine and albite, checking various directions).
This uses stishovite as an example. However, this shows we have a bug that needs to be fixed.
Collaborator
Author
|
Getting there - but we have a bug in axes for stishovite (see the notebook) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet ready to merge
Partial implementation (and tests) of the Browaeys and Chevrot tensor decomposition by symmetry. Thus far this implements the calculation of norms and decomposition, but code to find the axes is not yet written. This needs a rotation function adding too,