Open
Conversation
Member
|
So this IIUC -- away from code -- implies error on execution of kernel. For runtime errors when launching the kernel by the MM, we need this: At the moment, these kind of runtime errors are ignored. When the callback is set, we can generate an exception, which will be catched by the try block. In general this patch looks fine, but we need to arm the runtime callback to generate exceptions too. |
glguida
previously approved these changes
Oct 27, 2025
glguida
reviewed
Oct 27, 2025
ggml/src/ggml-et/ggml-et-kernels.cpp
Outdated
| // Skip uninitialized contexts (debug fill pattern 0xcdcdcdcdcdcdcdcd) | ||
| if (ctx.type_ == 4 && ctx.hartId_ != 0xcdcdcdcdcdcdcdcdULL) { | ||
| int64_t kernel_return_code = ctx.userDefinedError_; | ||
| GGML_LOG_ERROR("ET: Kernel '%s' returned error code %lld on hart %lld (shire %lld)\n", |
Member
There was a problem hiding this comment.
It would be very useful to print the device number here, too.
While this code is correct, I wonder if the Stream Error callback with exception is actually the right mechanism, instead of manually parsing the error.
e684bec to
d88b94c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check kernel errors (return values).
Fail and complain loudly if kernel execution fails. Skips empty contexts (you don't want ~1000 debug blocks if one thread failed)(do you?).
@glguida I just remembered that I have this commit in my "working branch" - only checks for user errors, but could be a starting point to understand other kernel launching issues. Didn't find stream callbacks necessary in this case.