Skip to content

docs(task): AgentSkill sample code written incorrectly#735

Open
aihai wants to merge 1 commit intoagentscope-ai:mainfrom
aihai:fix-#734
Open

docs(task): AgentSkill sample code written incorrectly#735
aihai wants to merge 1 commit intoagentscope-ai:mainfrom
aihai:fix-#734

Conversation

@aihai
Copy link

@aihai aihai commented Feb 5, 2026

AgentScope-Java Version

1.0.9
[The version of AgentScope-Java you are working on, e.g. 1.0.8, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

Description

Fixes: #734
[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@aihai aihai requested a review from a team February 5, 2026 09:22
@gemini-code-assist
Copy link

Summary of Changes

Hello @aihai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request rectifies an error in the AgentSkill sample code presented in the documentation. The update ensures that the example for creating an AgentSkill instance accurately reflects the API's intended usage, thereby enhancing the precision and usability of the developer documentation for both English and Chinese audiences.

Highlights

  • Documentation Correction: The sample code for initializing an AgentSkill object in both English and Chinese documentation has been corrected. The incorrect new AgentSkill.builder() has been updated to the proper AgentSkill.builder().
Changelog
  • docs/en/task/agent-skill.md
    • Corrected the AgentSkill builder instantiation from new AgentSkill.builder() to AgentSkill.builder() in the Java code example.
  • docs/zh/task/agent-skill.md
    • Corrected the AgentSkill builder instantiation from new AgentSkill.builder() to AgentSkill.builder() in the Java code example.
Activity
  • No human activity has been recorded on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a mistake in the Java sample code for AgentSkill in both the English and Chinese documentation. The change removes the new keyword from new AgentSkill.builder(), which is the correct way to invoke the static builder method. The change is accurate and improves the quality of the documentation. Well done.

@cla-assistant
Copy link

cla-assistant bot commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Feb 5, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fang-tech
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]AgentSkill sample code written incorrectly

2 participants