Refonte - Trésorerie - Journal - Export #2077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgreb
force-pushed
the
refacto/accounting-journal-export
branch
2 times, most recently
from
4f0ac3b to
34bbce0
Compare
vgreb
force-pushed
the
refacto/accounting-journal-export
branch
from
34bbce0 to
d18ddfa
Compare
vgreb
requested review from
Mopolo and
stakovicz
and removed request for
Mopolo
stakovicz
approved these changes
Jan 5, 2026
Contributor
|
ℹ️ On s'en sert beaucoup à la tréso donc je vais faire un test avec des données de prod. |
vgreb
force-pushed
the
refacto/accounting-journal-export
branch
2 times, most recently
from
789ba90 to
4d4d104
Compare
Mopolo
requested changes
Jan 10, 2026
| public function __invoke(Request $request): Response | ||
| { | ||
| $periodId = $request->query->has('periodId') && !empty($request->query->get('periodId')) ? $request->query->getInt('periodId') : null; | ||
| $alsoDisplayClassifed = $request->query->getBoolean('alsoClassified'); |
Contributor
There was a problem hiding this comment.
Dans le template c'est also_display_classifed_entries le paramètre donc ça ne va pas fonctionner.
J'en profite pour proposer de renommer ce paramètre en with_reconciled pour être plus exact en anglais. (dans ce controller uniquement, pas besoin de toucher aux variables dans les anciennes pages).
| # Export Excel | ||
| When I follow "Exporter la période en CSV" | ||
| Then the response header "Content-disposition" should match '#^attachment; filename="AFUP_(.*)_journal_from(.*).csv"#' | ||
| Then the response header "content-disposition" should match '#^attachment; filename=AFUP_(.*)_journal_from(.*).csv#' |
Contributor
There was a problem hiding this comment.
Est-ce que tu peux ajouter une assertion sur le contenu du fichier ?
On a déjà une phrase qui le fait, check dans tests/behat/features/Admin/Events/Conferences.feature
vgreb
force-pushed
the
refacto/accounting-journal-export
branch
from
4d4d104 to
46a09a1
Compare
vgreb
force-pushed
the
refacto/accounting-journal-export
branch
from
46a09a1 to
de24339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2074