This repository was archived by the owner on Sep 10, 2024. It is now read-only.

Many bug fixes and misc. improvements#35

Open

TylerRick wants to merge 40 commits intoadjust:masterfrom

TylerRick:synchronous_middleware

Commits on Nov 28, 2013

Improve some formatting, fix some typos, and add some clearer descriptions to the Readme file.
TylerRick
committed
Fix: The args passed to phantomjs command were not shell escaped.
TylerRick
committed
Add cmd back in (but escape the arguments this time) so that we can output the command exactly as it
TylerRick
committed
Add a debug configuration option that you can enable if you want to see details such as the
TylerRick
committed
Minor cleanup in middleware_spec.rb
TylerRick
committed
Add new html_url method. Fix it to work for the case where the request URL contains a query string.
TylerRick
committed
Add some debug output to the middleware (only enabled if the debug option is set to true)
TylerRick
committed
Extract some code out of the main Middleware class into a new BaseMiddleware class.
TylerRick
committed
Extracted out a new rendering_started_at method to make it clearer what the "rendering_flag"
TylerRick
committed
Extract out two new methods, pdf_body and pdf_headers, into base class to simplify render_as_pdf!
TylerRick
committed
Add some tests specifically for rendering_in_progress?, already_rendered?, and up_to_date?
TylerRick
committed
Fix commented-out "should render a pdf file" test
TylerRick
committed
Spell out test_file as 2 words.
TylerRick
committed
Actually create an expectation from the value that valid_pdf returns.
TylerRick
committed
Move test_file and valid_pdf to spec_helper.rb so that they can be reused from various test files.
TylerRick
committed
Add app, main_app, and middleware_options methods to spec_helper.rb so that they can be reused from
TylerRick
committed
Checking start_with? is simpler than matching a Regexp.
TylerRick
committed
Set the tmpdir to a random, temporary dir in the tests instead of to Dir.tmpdir (which is a fixed
TylerRick
committed
Add matching reader methods to Configuration for each option that already has a writer method.
TylerRick
committed
Change the default value for the tmpdir option to use mktmpdir (a subdirectory within /tmp like
TylerRick
committed
Rename fire_phantom to render_pdf to be more consistent with other methods like render_as_pdf and
TylerRick
committed
Moved the render_pdf method to BaseMiddleware so that it can be reused by both the current
TylerRick
committed
Merge the options that were passed in to the middleware with the options configured in
TylerRick
committed
Remove duplication between run and run! methods.
TylerRick
committed
Add page_load_error and page_load_status_code methods to Phantom.
TylerRick
committed
Add full response details to what rasterize.js outputs so that we can get the redirect URL, etc.
TylerRick
committed
Add a simpler middleware, SynchronousMiddleware, that runs the phantomjs command synchronously and
TylerRick
committed
Simple change to make the Middleware thread-safe: Only make changes to instance variables on a copy
TylerRick
committed
Remove a commented-out check for headers['Content-Type'].
TylerRick
committed
Parse the response_headers from the response that PhantomJS receives
TylerRick
committed
Make it possible to control which filename should be used for the downloaded PDF file, by having the
TylerRick
committed

Commits on Aug 5, 2014

Just render directly to the output file instead of the complication of renaming from '_tmp.pdf'.
TylerRick
committed

Commits on Oct 22, 2014

Allow content disposition (inline or attachment) to be specified with a X-Pdf-Disposition header.
TylerRick
committed

Commits on Dec 21, 2016

Allow page number in header and footer
Chuck Yang
committed

Commits on Dec 26, 2016

added .to_time for rendering_timed_out?
Chuck Yang
committed

Commits on Apr 28, 2017

Fixing file corrupted when rendering_time is small
Chuck Yang
committed

Commits on May 4, 2017