refactor: adjust the fallback logic#2
Merged
danieleloscozzese merged 11 commits intomainfrom Jan 11, 2025
Merged
Conversation
Remove the idle callback which was misused Add a microtask alternative for user-blocking tasks
Align with the implementation details
Might as well be consistent with the globalThis use
danieleloscozzese
force-pushed
the
simplify-logic
branch
from
49f5d89 to
fbba31f
Compare
danieleloscozzese
added a commit
to danieleloscozzese/post-task
that referenced
this pull request
Jan 12, 2025
Removes the Idle Callback fallback and uses timeouts directly. Adds the queueMicrotask as a fallback for user-blocking tasks, since it yields and queues the callback with the highest priority (in the micro task and not macro task queue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestIdleCallbackwas being misused here.The type of tasks to be co-operatively scheduled in idle time are not the same type of task which can be queued with a rough priority.
Removes the fallback and uses timeouts directly.
Adds the
queueMicrotaskas a fallback for user-blocking tasks, since it yields and queues the callback with the highest priority (in the micro task and not macro task queue).