Draft
Conversation
… trace_event_task_switch function signature
…rior and new tasks on task-switch event (TODO: record OTF2_EvtWriter_ThreadTaskSwitch)
…SWITCH flag defined at compilation
…for the purpose of allowing a task-switch event to record the task that was switched as the encountering task rather than its parent
…ng on one specific abstraction per file
…le. Add basic serial events
… this >.<) Fix broken package_data path in setup.py
… __LINE__ const values from caller to otter-serial Print source location of calling function to stderr
Add Source namespace - implements objects for mapping file-line tuples to opaque objects representing information needed for OTF2 to define source location
…be passed on to otter-trace via trace_new_task_region
…t struct, populate in trace_new_task_region, add to event attributes in trace_add_task_attributes (for create/enter/leave events)
…g refs to global definitions when char_ref_registry *Registry is deleted
implement source location in otter-serial
Author
|
I think I'll also address #3 here and try to convert that code into the new version of the library. |
Owner
|
Hi Aidan, looks like you've forked from my personal Otter repo which is an outdated version of the project. It's now hosted here: https://github.com/Otter-Taskification/otter I think if you fork from this tag over there you'll have an easier time with your PR. My apologies, I should have made it clear which repo we're working from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Adam,
I'm a bit confused how this has ended up 71 commits ahead of dev. I tried to move my fork to be the same as the base repository and somehow ended up here.
Is this all old/deleted/? code or has something gone wrong at my end. If its really badly messed up, I'll delete my fork and refork it, then readd the new modifications.
Edit: I tried basing on v0.1.0 and cherry-picking across my changes, but then the CMakeLists.txt weren't compatible :(