Skip to content

Conversation

@SpicyBagpipes
Copy link
Contributor

When merged this pull request will:

  • Move a single number to a unit variable

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Contributor Author

Would like to move more of oxygen to API but this is perfectly fine for my purposes

Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a proper API

Doing more with this is on my TODO list, but I have a long TODO list

Adding a variable in like this is not ideal and something that will either need to be supported in the future, or break things when removed

@SpicyBagpipes
Copy link
Contributor Author

SpicyBagpipes commented Dec 31, 2025

I think we should add a proper API

Doing more with this is on my TODO list, but I have a long TODO list

Adding a variable in like this is not ideal and something that will either need to be supported in the future, or break things when removed

What would you suggest? The only other idea I had was something along the lines of duty factors for oxygen but with how limited in scope current SPO2 implementation is I do not see many (any) hooks for API in it

@BrettMayson
Copy link
Member

Yes, that's how I would propose doing it, but an API needs to be added to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants