vehicles - update autothrottle to use future CBA pid component #11158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCandianVendingMachine
added
kind/enhancement
LinkIsGrim
reviewed
Dec 13, 2025
| GVAR(speedLimit) = _speedLimitMS * 3.6; | ||
| }; | ||
|
|
||
| private _pid = [4.00, 0.60, 2.50, _speedLimitMS, -1e30, 1e30, 60 * 3] call CBA_pid_fnc_create; |
Contributor
There was a problem hiding this comment.
engineers will get it but this feels a bit too magic number-y, can you move to defines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.