Fix HTML rendering of relationship variables in CiceroMark#637
Open
Aradhana2803 wants to merge 1 commit intoaccordproject:mainfrom
Open
Fix HTML rendering of relationship variables in CiceroMark#637Aradhana2803 wants to merge 1 commit intoaccordproject:mainfrom
Aradhana2803 wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: aradhana2803 <aradhanasingh2803@gmail.com> git push --force origin fix/relationship-variable-html
154e571 to
7c5caf5
Compare
Author
|
This PR fixes the issue reported in template-playground#13 where relationship-typed CiceroMark variables were rendered as quoted resource: strings instead of a readable identifier. HTML rendering now preserves the identifier cleanly, while keeping other variable types unchanged.Verified that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HTML rendering of relationship variables in CiceroMark
Related to accordproject/template-playground#13
Summary
Relationship-typed CiceroMark variables were rendered in HTML as quoted
resource:strings instead of a readable identifier. This PR fixes theHTML rendering logic so relationship variables display correctly.[TemplateMark not rendering relationships "resource" data #13]
Changes
ToHtmlStringVisitorto detect relationship variables viaelementTypeFlags
Screenshots or Video
Not applicable — behavior verified via existing HtmlTransformer test suite.
Author Checklist
--signoffoption of git commitmainfromfork:branchname