Take element height into consideration in colorize function#35
Open
damirkotoric wants to merge 1 commit intoabpetkov:masterfrom
damirkotoric:master
Open
Take element height into consideration in colorize function#35damirkotoric wants to merge 1 commit intoabpetkov:masterfrom damirkotoric:master
damirkotoric wants to merge 1 commit intoabpetkov:masterfrom
damirkotoric:master
Conversation
The colorise function now takes the element height into consideration when animating, which makes the animation look as intended when the switch is customised.
Author
Owner
|
I can't merge this as it is right now. What I agree on, is that the shadow behaviour is not 100% equivalent to the native iOS7 switch - the shadow animation should end before the handle animation. But you're just changing the size, which as we can see in your preview, leaves a slight transparent layer over the switch color during animation. And this doesn't make it any better. Honestly, I like it better as it is now. So if you're willing to do try to mimic iOS7 behaviour and make it exactly the same, I'll be glad to review that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The colorise function now takes the element height into consideration
when animating, which makes the animation look as intended when the
switch is customised.