Fix missing null checks when debug logging request information #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some types of errors (e.g. early connection failures), `CURLINFO_EFFECTIVE_URL` and `CURLINFO_SCHEME` might not ever get set, resulting in a segfault when trying to acces their contents.
Contributor
Author
|
random fun aside: I was actually been sitting on this and a fix for #188 for a month, because I pushed up the branch and completely forgot to actually open the PR 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some types of errors (e.g. early connection failures),
CURLINFO_EFFECTIVE_URLandCURLINFO_SCHEMEmight not ever get set, resulting in a segfault when trying to acces their contents.