-
Notifications
You must be signed in to change notification settings - Fork 7
Build package for Linux aarch64 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
No need to self host under https://apps.egiz.gv.at/maven/org/eclipse/swt/
| <version>4.35</version> | ||
| <groupId>org.eclipse.platform</groupId> | ||
| <artifactId>org.eclipse.swt.gtk.linux.aarch64</artifactId> | ||
| <version>3.129.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the only thing I don't really understand - why do you depend on the win32 artifacts?
Not sure if it is OK to just switch to the linux aarch64 artifacts here.
Or should the dependency be marked as provided?
77d3a0e to
4be7b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not trust me with this binary, please download it yourself from https://adoptium.net/de/temurin/releases?version=21&os=linux&arch=aarch64&mode=filter
|
BTW: (It says In case you try this PR on a aarch64 machine and did install the current x86_64 app before, you should always remove the |
|
Just letting you know that I've seen your pull requests, but am unlikely to have time to address them before the new year. |
|
There is absolutely no hurry. |
org.eclipse.swttoorg.eclipse.platform#167 (and is based on it, see the first commit of this PR)All I did was basically just copying the
linuxmaven profile and created thelinux-aarch64one, with everything changed to aarch64.Same for the GitHub actions workflow.
The only thing I do not understand is why in
pdf-over-commons/pom.xmlyou havewin32.x86_64hardcoded as dependency?I had to change that to the aarch64 ones to make things work for me - but I think there needs to be a more general solution?
Anyway, with this PR I am now able to run PDF-Over successfully on my Linux aarch64 system - with PDF signing via ID Austria working successfully.
(I am running Asahi Linux on my MacBook Pro M1. Actually, not the reference distribution Fedora Asahi Remix, but Asahi Arch Linux ARM (which I am also maintaining)).