[Draft] Persist agency filter when clicking on panel#540
Open
[Draft] Persist agency filter when clicking on panel#540
Conversation
FaustineG
force-pushed
the
persist-agency-filter
branch
from
a1a3015 to
476b36f
Compare
MailyLehoux
suggested changes
Feb 7, 2023
Contributor
MailyLehoux
left a comment
MailyLehoux
left a comment
There was a problem hiding this comment.
Coucou merci pour ta contribution 💯 c'est pas quelque chose à laquelle on a pensé ! et c'est plus pratique
| query: "(min-device-width: 1280px)", | ||
| }); | ||
|
|
||
| const linkUrl = new URL(window.location.origin, `/skills/${context}/${name}`); |
Contributor
There was a problem hiding this comment.
Suggested change
| const linkUrl = new URL(window.location.origin, `/skills/${context}/${name}`); | |
| const linkUrl = new URL(`${config.nextPublicBaseUrl}/skills/${context}/${name}`); |
| const currentUrl = new URL(window.location.href); | ||
| if (currentUrl.searchParams.get("agency")) | ||
| linkUrl.searchParams.set("agency", currentUrl.searchParams.get("agency")); | ||
|
|
Contributor
There was a problem hiding this comment.
On a besoin de garder ça quand meme. Dans l'idée ça réduit les clics pour un nouvel arrivant qui n'a aucune données
Suggested change
| if (context === "mine" && !data.length) | |
| linkUrl.searchParams.append("add", "true") |
Contributor
|
@FaustineG, tu voudra qu'on s'occupe de faire les modifs ? 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malheureusement je n'ai pas réussi a lancer l'app en local, donc je n'ai pas pu tester du tout, mais lorsque je clique sur un graphe, je trouverais ça cool que le choix de filtre d'agence soit persisté.
Je n'ai pas compris à quoi servait la partie
query: !data.length && context === "mine" && { add: true }et j'ai bidouillé ça très vite, dans le noir, donc hésitez pas à virer si ça marche pas :)