Upgrade dependencies#52
Conversation
Upgrade ring to 0.14
|
Don't know why one check succeeded and another failed |
|
Looks like it randomly failed at |
|
yes, there's an issue I think about it. it s a probabilistic test and therefore it fails once in a while |
|
coincidence I would say. |
|
Cool, I guess it's better to remove |
|
@omershlo |
|
Yes, I was planning on doing it over the weekend. My main issue is with updates to secp256k1 library. I need to make sure what changes are included in that version and why not bump it to the latest |
I guess I know why. let l63 = BigInt::from_str_radix(
"96208c61220f2cce171f0c1d10db7c094245fb66b17b9de3e0c4fbf4e68e73d",
16,
)
.unwrap();
assert_eq!(l63.to_str_radix(16).len(), 63);let l63 = BigInt::from_str_radix(
"096208c61220f2cce171f0c1d10db7c094245fb66b17b9de3e0c4fbf4e68e73d",
16,
)
.unwrap();
assert_eq!(l63.to_str_radix(16).len(), 63); |
|
And since |
|
This check is indeed problematic because of the probabilistic nature. Do you suggest we just remove it ? |
|
I'll remove it in #61 |
No description provided.