This repository was archived by the owner on May 13, 2025. It is now read-only.
Added OutOfMemory catch and retry for loading images from the file syste...#8
Open
mesyelp wants to merge 1 commit intoYelpArchive:masterfrom
Open
Added OutOfMemory catch and retry for loading images from the file syste...#8mesyelp wants to merge 1 commit intoYelpArchive:masterfrom
mesyelp wants to merge 1 commit intoYelpArchive:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Not sure, but I think it's better to rethrow the OutOfMemoryError after it fails for the second time. Swallowing that Error will probably make the JVM unstable afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...m