chore: Remove SearchForm and Combobox from Labs #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
ISSUE-3656
|
| Run status |
|
| Run duration | 02m 21s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
86
|
Skipped
|
0
|
Passing
|
812
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.27%
|
|
|---|---|
|
Untested elements
|
1531
|
|
Tested elements
|
363
|
Accessibility
99.52%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
71
|
alanbsmith
changed the title
alanbsmith
force-pushed
the
ISSUE-3656
branch
3 times, most recently
from
a59c375 to
3ac0431
Compare
alanbsmith
commented
Dec 31, 2025
| <WorkdayLogo dangerouslySetInnerHTML={{__html: dubLogoPrimary}} /> | ||
| </Hyperlink> | ||
| </GlobalHeader.Item> | ||
| <GlobalHeader.Item margin="auto" width="100%" maxWidth={`calc(${space.xxxl} * 6)`}> |
Member
Author
There was a problem hiding this comment.
Removing this from the Nav in the example.
alanbsmith
force-pushed
the
ISSUE-3656
branch
from
3ac0431 to
bed3044
Compare
mannycarrera4
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3656
Removes the deprecated
SearchFormandComboboxcomponents from@workday/canvas-kit-labs-react, including all source code, tests, stories, and documentation.Release Category
Components
Release Note
The following labs components have been removed:
SearchForm(and related exports:SearchFormProps,SearchFormState,SearchTheme,SearchThemeAttributes)Combobox(and related exports:ComboboxProps,AutocompleteList,Status)BREAKING CHANGES
The following exports are no longer available from
@workday/canvas-kit-labs-react:Combobox,ComboboxProps,AutocompleteList,StatusSearchForm,SearchFormProps,SearchFormState,SearchTheme,SearchThemeAttributesUsers should migrate to the main
@workday/canvas-kit-react/comboboxcomponent.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
modules/labs-react/index.tsAreas for Feedback? (optional)
Testing Manually
@workday/canvas-kit-labs-reactno longer exportsSearchFormorComboboxScreenshots or GIFs (if applicable)
N/A - This is a removal of deprecated components