Skip to content

Conversation

@mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Dec 9, 2025

Summary

Fixes: #2088

Release Category

Components

Release Note

We've promoted Pill from Preview to Main. There are no changes to the
functionality or styling of the component. The only change required is updating the import
statement.

Before in v14

import {Pill} from '@workday/canvas-kit-preview-react/pill';

After in v15

import {Pill} from '@workday/canvas-kit-react/pill';

🤖 The codemod will handle the change of imports as shown above.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@cypress
Copy link

cypress bot commented Dec 9, 2025

Workday/canvas-kit    Run #10006

Run Properties:  status check passed Passed #10006  •  git commit c2a1277753 ℹ️: Merge 2f803f1a4d52e57361faee43ae3c22fdcf3914c4 into 3fbdd82f3f92e4c6aaebd87c84fc...
Project Workday/canvas-kit
Branch Review mc-promote-pills
Run status status check passed Passed #10006
Run duration 02m 13s
Commit git commit c2a1277753 ℹ️: Merge 2f803f1a4d52e57361faee43ae3c22fdcf3914c4 into 3fbdd82f3f92e4c6aaebd87c84fc...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 86
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 812
View all changes introduced in this branch ↗︎
UI Coverage  19.31%
  Untested elements 1527  
  Tested elements 363  
Accessibility  99.52%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 71  

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the Pill component from the Preview package (@workday/canvas-kit-preview-react/pill) to the Main package (@workday/canvas-kit-react/pill), making it a stable production-ready component.

Key Changes:

  • Migrated all Pill component implementation files from preview to main package
  • Updated import paths across all consuming files (stories, examples, tests, and dependent components)
  • Modified Storybook titles from "Preview/Pill" to "Components/Indicators/Pill"

Reviewed changes

Copilot reviewed 14 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/react/pill/lib/*.tsx New component implementation files for Pill and its subcomponents
modules/react/pill/stories/*.ts(x) Updated imports and Storybook metadata to reference main package
modules/react/pill/spec/SSR.spec.tsx Added SSR test for the promoted component
modules/react/pill/index.ts New main package exports (contains duplicate export)
modules/react/index.ts Added Pill to main package exports
modules/preview-react/index.ts Removed Pill export from preview package
modules/preview-react/multi-select/lib/MultiSelectedItem.tsx Updated import to use main package
cypress/component/Pill.spec.tsx Updated imports and test context descriptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mannycarrera4 mannycarrera4 moved this to 🏗 In progress in Canvas Kit Dec 30, 2025
@mannycarrera4 mannycarrera4 marked this pull request as ready for review December 30, 2025 15:38
@mannycarrera4 mannycarrera4 moved this from 🏗 In progress to 👀 In review in Canvas Kit Dec 30, 2025
@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Dec 30, 2025
Copy link
Member

@alanbsmith alanbsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mannycarrera4. Some relatively minor nits from me. Mostly looks like too many backticks are being added. Storybook seems to render fine, but it's a bit odd.

I'm going to go ahead and approve so you're unblock and can move forward.

@alanbsmith alanbsmith added approved Code has been reviewed and approved (ship it) and removed ready for review Code is ready for review labels Dec 31, 2025
@mannycarrera4 mannycarrera4 added this to the 15.0.0 milestone Dec 31, 2025
@alanbsmith alanbsmith merged commit 85c5dfa into Workday:prerelease/major Dec 31, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15.x approved Code has been reviewed and approved (ship it) automerge

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants