-
Notifications
You must be signed in to change notification settings - Fork 242
feat: Promote Pill from Preview to Main package #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Promote Pill from Preview to Main package #3634
Conversation
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-promote-pills
|
| Run status |
|
| Run duration | 02m 13s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
86
|
|
|
0
|
|
|
812
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.31%
|
|
|---|---|
|
|
1527
|
|
|
363
|
Accessibility
99.52%
|
|
|---|---|
|
|
5 critical
5 serious
0 moderate
2 minor
|
|
|
71
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR promotes the Pill component from the Preview package (@workday/canvas-kit-preview-react/pill) to the Main package (@workday/canvas-kit-react/pill), making it a stable production-ready component.
Key Changes:
- Migrated all Pill component implementation files from preview to main package
- Updated import paths across all consuming files (stories, examples, tests, and dependent components)
- Modified Storybook titles from "Preview/Pill" to "Components/Indicators/Pill"
Reviewed changes
Copilot reviewed 14 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/react/pill/lib/*.tsx | New component implementation files for Pill and its subcomponents |
| modules/react/pill/stories/*.ts(x) | Updated imports and Storybook metadata to reference main package |
| modules/react/pill/spec/SSR.spec.tsx | Added SSR test for the promoted component |
| modules/react/pill/index.ts | New main package exports (contains duplicate export) |
| modules/react/index.ts | Added Pill to main package exports |
| modules/preview-react/index.ts | Removed Pill export from preview package |
| modules/preview-react/multi-select/lib/MultiSelectedItem.tsx | Updated import to use main package |
| cypress/component/Pill.spec.tsx | Updated imports and test context descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alanbsmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mannycarrera4. Some relatively minor nits from me. Mostly looks like too many backticks are being added. Storybook seems to render fine, but it's a bit odd.
I'm going to go ahead and approve so you're unblock and can move forward.
Summary
Fixes: #2088
Release Category
Components
Release Note
We've promoted
Pillfrom Preview to Main. There are no changes to thefunctionality or styling of the component. The only change required is updating the import
statement.
Before in v14
After in v15
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)