Move minimist to devDependencies and exclude bin/ from package#93
Open
ricsantos wants to merge 1 commit intoWizcorp:masterfrom
Open
Move minimist to devDependencies and exclude bin/ from package#93ricsantos wants to merge 1 commit intoWizcorp:masterfrom
ricsantos wants to merge 1 commit intoWizcorp:masterfrom
Conversation
minimist is only used in the bin/ CLI scripts for manual testing/debugging, not in the actual library code consumed by third parties. This change: - Moves mini mist from dependencies to devDependencies - Adds .npmignore to exclude bin/ directory from published package - Reduces package size and removes unnecessary dependency for consumers - Eliminates exposure to minimist vulnerabilities (0.0.8 has known issues) The bin/ scripts remain available for development but won't be shipped to users who install this package.
Author
|
@ronkorving @jrouault any chance this could be merged in and a release made? Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimist is only used in the bin/ CLI scripts for manual testing/debugging, not in the actual library code consumed by third parties. This change:
The bin/ scripts remain available for development but won't be shipped
to users who install this package.
See issues #77 and #89