Conversation
- Remove global safe-area padding in `App.tsx` to enable immersive headers. - Remove `minHeight: 100vh` to prevent scroll issues on iOS. - Update `GameRoom.tsx` header to handle safe area padding locally. - Add `MobileDateInput` component to address user request for better date input sizing. Co-authored-by: WeixuanZ <39925558+WeixuanZ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses reported mobile layout issues including excessive margins below navbars and unnecessary vertical scrolling on iOS.
Changes:
paddingTop: 'env(safe-area-inset-top)'fromApp.tsx. This was pushing all content down, creating gaps below navbars if they were intended to be immersive.minHeight: '100vh'from the root container inApp.tsx, which can cause overflow on mobile browsers where100vhignores the URL bar.height: '100dvh'is sufficient.GameRoom.tsxto explicitly add safe-area padding to its sticky header (paddingTop: 'calc(16px + env(safe-area-inset-top))'), ensuring content isn't obscured by the notch while maintaining the immersive background.MobileDateInputcomponent infrontend/src/components/MobileDateInput.tsxthat wraps the native date picker with a custom, touch-friendly UI, solving the "wrong sizing" and "intuitive use" issues reported by the user.PR created automatically by Jules for task 5554837315683243399 started by @WeixuanZ