Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Nov 30, 2025

Description

This PR makes pyvista dependencies optional through the specifier viz.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson December 1, 2025 17:15
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had a few questions/comments but overall very nice and clean addition and protections added.

@d33bs d33bs marked this pull request as ready for review December 1, 2025 19:02
d33bs and others added 2 commits December 1, 2025 12:07
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
@d33bs
Copy link
Member Author

d33bs commented Dec 1, 2025

Thanks @jenna-tomkinson !

@d33bs d33bs merged commit 33b9253 into WayScience:main Dec 1, 2025
9 checks passed
@d33bs d33bs deleted the view-optional branch December 1, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants