fix lost query and return for get_expressed_genes_by_cell_and_gene_type #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie1977
previously approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the get_expressed_genes_by_cell_and_gene_type method that was broken after a previous commit. The missing query execution and return logic has been restored.
Key Changes
- Added missing query execution and result processing logic
- Added
verboseparameter for debugging support - Updated return value documentation from "Empty DataFrame" to "False"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Robbie1977 I've opened a new pull request, #267, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] Update get_expressed_genes_by_cell_and_gene_type based on feedback
Robbie1977
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken after 94938dc but not shown in diff