Skip to content

Conversation

Copy link

Copilot AI commented Dec 13, 2025

FedRAG Pull Request Template

Thanks for contributing to FedRAG!
Please fill out the sections below to help us review your PR efficiently.

Summary

What does this PR do? Please provide a brief summary of the changes introduced.

  • Bug fix
  • New feature
  • Documentation update
  • Code quality / linting
  • Other (please describe):

Description

CI checks were failing due to outdated lock file and Pydantic V2.11 deprecation warnings.

Changes

Dependency synchronization

  • Updated uv.lock to resolve version drift across CI environments (Python 3.10, 3.11, 3.12)

Pydantic V2.11 compatibility

  • Fixed deprecated self.model_fieldsself.__class__.model_fields in:
    • base/trainer_config.py: __init__, __getattr__, __setattr__
    • fl_tasks/pytorch.py: __getattr__
    • fl_tasks/huggingface.py: __getattr__

Accessing model_fields from instances is deprecated in Pydantic V2.11. The fix maintains identical runtime behavior while eliminating 76 deprecation warnings.

Testing

Describe how you tested your changes. Include the steps to reproduce, commands run, and any relevant outputs.

  • Unit tests added or updated
  • All tests pass locally (make test)
  • Code coverage maintained or improved

Checklist

Before submitting your PR, please check off the following:

  • My code follows the existing style and conventions
  • I've run linting (make lint)
  • I've added/updated relevant documentation
  • I've added/updated tests as needed
  • I've verified integration with existing tools (HuggingFace, LlamaIndex, LangChain, etc. if applicable)
  • I've added an entry to the CHANGELOG.md (if applicable)

Related Issues or PRs

If this PR addresses or relates to existing issues or pull requests, link them here:

N/A

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Clear the open PRs. The checks are failing.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 13, 2025
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.66%. Comparing base (a987fe6) to head (e0c1b38).

Files with missing lines Patch % Lines
src/fed_rag/base/trainer_config.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files         156      156           
  Lines        4119     4119           
=======================================
  Hits         4064     4064           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI and others added 2 commits December 13, 2025 22:22
Co-authored-by: nerdai <92402603+nerdai@users.noreply.github.com>
Co-authored-by: nerdai <92402603+nerdai@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove open pull requests due to failing checks Fix CI checks: update dependencies and resolve Pydantic V2.11 deprecations Dec 13, 2025
Copilot AI requested a review from nerdai December 13, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants