Full-width characters compatibility and max_width adjustability#30
Open
maplexgitx0302 wants to merge 2 commits intoVaasuDevanS:mainfrom
Open
Full-width characters compatibility and max_width adjustability#30maplexgitx0302 wants to merge 2 commits intoVaasuDevanS:mainfrom
max_width adjustability#30maplexgitx0302 wants to merge 2 commits intoVaasuDevanS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Chinese characters are full-width (twice larger than half-width characters, e.g., ASCII characters), the previous version break lines corresponding to the length of a string but not the true width of the string. I tried to modified it so it can determine when to break lines correctly.
Also, I want to adjust the value of
max_width(default 49 characters). I simply add this argument for each functions so that I can adjust its value.