upipe_sync: Separate frame duplication into a "frame_sync" mode.#775
Open
kierank wants to merge 1 commit intoUpipe:masterfrom
Open
upipe_sync: Separate frame duplication into a "frame_sync" mode.#775kierank wants to merge 1 commit intoUpipe:masterfrom
kierank wants to merge 1 commit intoUpipe:masterfrom
Conversation
JDarnley
reviewed
Jan 5, 2021
Contributor
JDarnley
left a comment
JDarnley
left a comment
There was a problem hiding this comment.
Despite my other comments I think I haven't understood fully the changes. I can look again another time and if you have anything else to add to the commit.
This allows for a mode which receives audio and video and outputs the correct audio and video but doesn't retime to a local clock
Contributor
|
This still has not been merged. I believe we have been using this successfully in production. We have some more changes so let me see if any should be picked into this PR |
Contributor
|
@kierank I think you should cherry-pick 72c8e601b from our private code onto this PR because I think it is related. |
Collaborator
|
Should I wait for another commit or should I merge as-is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for a mode which receives audio and video and outputs the correct audio and video but doesn't retime to a local clock