Add support for FFmpeg's draw_horiz_band feature#508
Open
JDarnley wants to merge 11 commits intoUpipe:masterfrom
Open
Add support for FFmpeg's draw_horiz_band feature#508JDarnley wants to merge 11 commits intoUpipe:masterfrom
JDarnley wants to merge 11 commits intoUpipe:masterfrom
Conversation
…nd field attributes Also don't set the same ones elsewhere.
cmassiot
requested changes
Sep 3, 2018
| } | ||
|
|
||
| if (frame->interlaced_frame) | ||
| UBASE_FATAL(upipe, uref_attr_set_void(flow_def_attr, NULL, UDICT_TYPE_VOID, "sepfields")); |
Collaborator
There was a problem hiding this comment.
Please use a macro to define a new attribute.
Collaborator
|
Is this pull request still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very experimental but does work together with row_join (#506) and some unpublished changes to uplay.