fix: Allow union of destinations in fulfillment tests #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Type of change
Please delete options that are not relevant.
functionality to not work as expected, including removal of schema files
or fields)
Is this a Breaking Change or Removal?
If you checked "Breaking change" above, or if you are removing any schema
files or fields:
!to my PR title (e.g.,feat!: remove field).Breaking Changes / Removal Justification
(Please provide a detailed technical and strategic rationale here for why this
breaking change or removal is necessary.)
Checklist
According to documentation, business should return: Available destinations. For shipping: addresses. For pickup: retail locations.
There is no mention in the documentation that after updating destination by a platform, only selected destination should be returned. It also doesn't fit pickup scenario (user doesn't know store locations).
This change relaxes the check to verify destinations include new destination.
Ideally it should compare lists before and after but then python implementation will fail the test (lets update it first before making the test strict).