Skip to content

Conversation

@semenovm
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

(Please provide a detailed technical and strategic rationale here for why this
breaking change or removal is necessary.)


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

According to documentation, business should return: Available destinations. For shipping: addresses. For pickup: retail locations.

There is no mention in the documentation that after updating destination by a platform, only selected destination should be returned. It also doesn't fit pickup scenario (user doesn't know store locations).

This change relaxes the check to verify destinations include new destination.

Ideally it should compare lists before and after but then python implementation will fail the test (lets update it first before making the test strict).

@semenovm semenovm requested a review from a team January 22, 2026 10:47
@semenovm semenovm force-pushed the allow_existing_destinations branch from 0263932 to ef35033 Compare January 22, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant