feat(pm-notifier): read order filled events from subgraph #4900
Conversation
|
|
||
| const orderBookSubgraphEndpoint = | ||
| env.ORDER_BOOK_SUBGRAPH_ENDPOINT || | ||
| "https://api.goldsky.com/api/public/project_cl6mb8i9h0003e201j6li0diw/subgraphs/orderbook-subgraph/0.0.1/gn"; |
There was a problem hiding this comment.
Defaults to the public version (https://docs.polymarket.com/developers/subgraph/overview#hosted-version)
md0x
changed the title
| // Try the fast subgraph version | ||
| return await getOrderFilledEventsFromSubgraph(params, clobTokenIds, startTimestamp); | ||
| } catch (error) { | ||
| // Fallback to the slow version if subgraph fails |
There was a problem hiding this comment.
should we debug log this for better observability
| const blockDifference = currentBlockNumber - subgraphBlockNumber; | ||
|
|
||
| // If subgraph is behind by more than tolerance, use slow method | ||
| if (blockDifference >= params.subgraphSyncTolerance) { |
There was a problem hiding this comment.
the subgraphSyncTolerance naming implies that == should still be tolerated, so we might want to use > comparison here. Also running this couple of times I always observed subgraph lagging 1 block behind in my tests.
| // Check subgraph sync status first | ||
| const subgraphBlockNumber = await checkSubgraphSyncStatus(params.httpClient, params.orderBookSubgraphEndpoint); | ||
|
|
||
| if (subgraphBlockNumber !== null) { |
There was a problem hiding this comment.
when subgraphBlockNumber === null I don't think we should even try getOrderFilledEventsFromSubgraph below and instead fallback to getOrderFilledEventsSlow as subgraphSyncTolerance cannot be evaluated in this case.
|
|
||
| // If subgraph is behind by more than tolerance, use slow method | ||
| if (blockDifference >= params.subgraphSyncTolerance) { | ||
| return await getOrderFilledEventsSlow(params, clobTokenIds, startBlockNumber); |
There was a problem hiding this comment.
also might want to debug log the fallback
Changes proposed in this PR: