Removed dependency on output file from most components and classes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of our components were dependent on the output_dir parameter, which was not necessary. This commit removes the dependency on output_dir from many of our components. - Components now return a datastructure, either a pandas dataframe or a numpy array. - This gives the user more flexibility in how they want to save the output of the component. - User can easy save the output to a csv file or pass the output to another component. - This follows common practices in popular machine learning frameworks such as scikit-learn, PyTorch, and TensorFlow. - By increasing flexibility and separation of concerns, we make our codebase more modular and easier to maintain. - Therefore adhering to the single-responsibility principle.
ramosv
requested review from
SundousHussein,
abdelhafizm,
arunangshu-github and
bdlab-ucd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our components were dependent on the output_dir parameter, which was not necessary. This commit removes the dependency on output_dir from many of our components.
Components now return a datastructure, either a pandas dataframe or a numpy array.
This gives the user more flexibility in how they want to save the output of the component.
User can easy save the output to a csv file or pass the output to another component.
This follows common practices in popular machine learning frameworks such as scikit-learn, PyTorch, and TensorFlow.
By increasing flexibility and separation of concerns, we make our codebase more modular and easier to maintain.
Therefore adhering to the single-responsibility principle.