🦋 metal: Remove inconsistent descriptor creators from Allocation
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
Allocation interface
MarijnS95
changed the title
Allocation
Member
|
Glad to see this finally happening after proposing it months ago. These things shouldn't have been there as they're inconsistent with our Vulkan and Dx12 backend, and above all provoked a terrible I've tried to retitle this PR to describe the specific bad pattern that you're removing, happy to see this reclarified/rewritten further if you have better ideas 👍 |
manon-traverse
approved these changes
Oct 15, 2024
MarijnS95
reviewed
Oct 15, 2024
MarijnS95
reviewed
Oct 15, 2024
MarijnS95
force-pushed
the
proper-metal-helpers
branch
4 times, most recently
from
39ad9b7 to
c79f38d
Compare
MarijnS95
force-pushed
the
proper-metal-helpers
branch
from
c79f38d to
7351ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers don't really belong in the metal implementation of GPU allocator, instead, they belong in the client APIs using gpu-allocator.
This issue surfaced in our codebase because the
make_acceleration_structurefunction didn't pass through all the required information.