Skip to content

Comments

Fix menu/camera input conflict and move light position to Light menu#10

Draft
Copilot wants to merge 6 commits intomasterfrom
copilot/add-lua-photo-mode
Draft

Fix menu/camera input conflict and move light position to Light menu#10
Copilot wants to merge 6 commits intomasterfrom
copilot/add-lua-photo-mode

Conversation

Copy link

Copilot AI commented Feb 20, 2026

Checklist

Links to issue(s) this pull request concerns (if applicable)

n/a

Description of pull request

Menu navigation and camera/player movement keys were processed simultaneously every freeze tick, causing inputs to fight (e.g. arrow keys triggering both menu selection and camera orbit).

Input separation

  • Menu input and movement controls are now mutually exclusive based on UI visibility
  • UI visible → menu navigation only
  • UI hidden → camera/player movement only
  • LOOK key toggles between modes (always available)
  • INVENTORY exits Photo Mode (moved from HandleMenuInput to OnFreeze so it's always available)

Light position moved to Light menu

  • Removed CTRL_LIGHT control mode from Camera menu (was confusing indirection)
  • Added Place at Camera and Place at Lara buttons directly in Light menu
  • Removed UpdateLightManualControls() — light positioning is now via menu buttons + the existing Source selector (Manual/Follow Camera/Follow Lara)

Other changes from prior commits

  • Outfit/Weapon selectors added to Outfit menu (SwapSkinnedMesh/UnswapSkinnedMesh)
  • UI only redraws on uiDirty flag (not every frame)
  • Mouse scroll zoom, LOOK-held orbit boost for camera
  • ClearAllKeys() at start of OnFreeze to prevent gameplay input leakthrough

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 20, 2026 20:26
Co-authored-by: TrainWrack <120750885+TrainWrack@users.noreply.github.com>
…et, add outfit/weapon selectors, optimize UI rendering

Co-authored-by: TrainWrack <120750885+TrainWrack@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Lua-based Photo Mode with object camera and dynamic light Add Lua Photo Mode (Object Camera) module Feb 20, 2026
Co-authored-by: TrainWrack <120750885+TrainWrack@users.noreply.github.com>
Copilot AI changed the title Add Lua Photo Mode (Object Camera) module Fix menu/camera input conflict and move light position to Light menu Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants